WIP: Using JNI+Rust instead of JNA on macOS #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 60.4% 77.9% +17.5%
- Complexity 147 171 +24
==========================================
Files 26 23 -3
Lines 812 768 -44
Branches 92 89 -3
==========================================
+ Hits 491 599 +108
+ Misses 270 106 -164
- Partials 51 63 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…s (instead of NIO data)
…g file to the parent folder
…t amount of changes (and remove unused code)
sungshik
force-pushed
the
feat/use-rust-and-jni-on-mac-wip
branch
from
6ea1016 to
f8276de
Compare
sungshik
changed the title
DavyLandman
approved these changes
Aug 11, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
Some small things to update, but looks good.
.github/workflows/build.yaml
Outdated
| distribution: 'temurin' | ||
| cache: 'maven' | ||
| #- uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| - run: ./update-rust-jni-libs.sh |
Member
There was a problem hiding this comment.
todo: we should publish these libs in a way that it's available for the release build of the maven lib.
or maybe just run maven package on a osx runner.
src/main/java/engineering/swat/watch/impl/mac/NativeEventHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/engineering/swat/watch/impl/mac/NativeLibrary.java
Outdated
Show resolved
Hide resolved
…pied dynamic libraries
DavyLandman
reviewed
Aug 13, 2025
…ormat` in pom.xml
DavyLandman
approved these changes
Aug 13, 2025
Member
DavyLandman
left a comment
DavyLandman
left a comment
There was a problem hiding this comment.
This looks good, thanks @sungshik for picking it up and finishing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the JNA based implementation with a rust based implementation. This reduces our dependencies (fixing #58) and allows us to improve the performance in future PRs by moving some logic to the rust side.